Skip to content

[Twenty-front]: Record table Header drag and drop functionality#21304

Open
git-init-priyanshu wants to merge 10 commits into
twentyhq:mainfrom
git-init-priyanshu:record-table/drag-drop-functionality
Open

[Twenty-front]: Record table Header drag and drop functionality#21304
git-init-priyanshu wants to merge 10 commits into
twentyhq:mainfrom
git-init-priyanshu:record-table/drag-drop-functionality

Conversation

@git-init-priyanshu

Copy link
Copy Markdown
Contributor

Closes #21303

Screen.Recording.2026-06-08.at.1.53.04.PM.mov

@twenty-ci-bot-public

Copy link
Copy Markdown

👋 Thanks for contributing to Twenty!

Your PR has been set to draft while you work on it. Once you're done, mark it as Ready for review and our automated checks will run.

Looking forward to your contribution!

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 8 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

@twenty-ci-bot-public

twenty-ci-bot-public Bot commented Jun 8, 2026

Copy link
Copy Markdown

🔍 Automated Pre-Review

No issues detected - This PR is ready for human review.


🧭 External PR Quality Review

🟠 Needs triage for the following reason(s):

  • Does not follow Twenty technical standards (4 issue(s))

cc @prastoin

Checks

  • CI: pending
  • 🔗 Linked issue: Closes #21303
  • 📐 Standards: 4 issue(s)

Detailed findings (duplicate candidates, standards notes, summary) are in the workflow run logs.


View details

Automated pre-review — human approval still required.

@FelixMalfait

Copy link
Copy Markdown
Member

Thanks! @Bonapara for design input

@Bonapara

Bonapara commented Jun 8, 2026

Copy link
Copy Markdown
Member
image
  1. Keep displaying the column where it is to avoid the following behavior
  2. It should be working wherever you release the column header
  3. Display a border blue to indicate where the item will get released

Figma: https://www.figma.com/design/xt8O9mFeLl46C5InWwoMrN/Twenty?node-id=102422-209812&t=34rYRPPi1ZzuuW1k-11

Your implem:

CleanShot.2026-06-08.at.17.28.47.mp4

Columns no longer aligned with content:

file-9a8108ab09364548512f4263179c956e

@git-init-priyanshu

Copy link
Copy Markdown
Contributor Author

Thanks @Bonapara for the design input. I will look into this and make changes.

@git-init-priyanshu

Copy link
Copy Markdown
Contributor Author

@Bonapara a quick question: Do I need to use the dnd-kit library or I can achieve the same result using hello-pangea/dnd library because I have used hello-pangea/dnd here ? What do you recommend?

@Bonapara

Bonapara commented Jun 9, 2026

Copy link
Copy Markdown
Member

@git-init-priyanshu @hello-pangea/dnd is still used in older table/board record drag-and-drop flows, but for this new column header reordering I'd rather align with the sidebar implementation and use dnd-kit.

@git-init-priyanshu

Copy link
Copy Markdown
Contributor Author

@git-init-priyanshu @hello-pangea/dnd is still used in older table/board record drag-and-drop flows, but for this new column header reordering I'd rather align with the sidebar implementation and use dnd-kit.

I figured. I was tinkering with @hello-pangea/dnd, but it doesn't seem possible to achieve that requirement, or at least not in an easy and reliable way. I'll make the changes and let you know. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Record Table: Columns Drag and Drop Functionality

3 participants